chore: Match ExpectApplied expectation implementation with implementation from karpenter core#121
Open
jeevanpuchakay wants to merge 1 commit intoawslabs:mainfrom
Open
Conversation
…tion from karpenter core
jeevanpuchakay
force-pushed
the
fix-ExpectApplied-implementation
branch
from
e339c5a to
d100e1e
Compare
| for _, o := range objects { | ||
| current := o.DeepCopyObject().(client.Object) | ||
| statuscopy := o.DeepCopyObject().(client.Object) // Snapshot the status, since create/update may override | ||
| deletionTimestampSet := !o.GetDeletionTimestamp().IsZero() |
Contributor
There was a problem hiding this comment.
I'm not sure that I'm convinced by the deletionTimestamp logic that's present here -- this might have been in the karpenter implementation, but I'm not sure that this makes sense and is something that we want to pull in here
Contributor
|
@jeevanpuchakay Looks like this PR has gone a bit stale. If we don't hear from you over the next couple weeks we'll move this to closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: kubernetes-sigs/karpenter#1348
Description of changes:
ExpectAppliedexpectation implementation with implementation from karpenter coreExpectApplied.ExpectAppliedmethod in operatorpkg.operatorpkgand use them in karpenter (core) package.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.